Streamline Forms #3908
Open
Streamline Forms #3908
+165
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-3908.dev.renku.ch |
ciyer
force-pushed
the
ciyer/form-improvements
branch
8 times, most recently
from
b5c8b5a to
8922c41
Compare
ciyer
force-pushed
the
ciyer/form-improvements
branch
4 times, most recently
from
7f07442 to
99fb111
Compare
ciyer
force-pushed
the
ciyer/form-improvements
branch
from
99fb111 to
92d1777
Compare
Member
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Lgtm!
Just a comment on the form label boldness
|
|
||
| // Make form labels bold | ||
| .form-label { | ||
| font-weight: bold; |
Member
There was a problem hiding this comment.
Labels now look very prominent. Should we use semibold instead?
Suggested change
| font-weight: bold; | |
| font-weight: $font-weight-semibold; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
The changes touch every form, but here are some images for comparison.
Project New
Session Launcher New
/deploy renku=release-2.11.0